Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test for is_straight_line_drawing #391

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Hermann-SW
Copy link

@Hermann-SW Hermann-SW commented Oct 12, 2024

For #388

@Hermann-SW
Copy link
Author

@jeremy-murphy
I created this failing testcase because you asked for that in #388.
Will the pull request be accepted before fix is available?
Or only after a fix will be provided making CIs green again?

@jeremy-murphy
Copy link
Contributor

Only after a fix is provided that makes it green. I understand that you're excited about this topic, but you will have to be patient. I do this maintenance voluntarily, so it has to come in between my full-time work and parenting, which doesn't leave much.

@jeremy-murphy
Copy link
Contributor

I wonder why CI / macos (clang) is green when it should be red like the others...

"crosses" fits the requirement as it means that the interior parts of the
geometry share some common points, not exterior parts such as
end-points, and it means "not within".
@jeremy-murphy
Copy link
Contributor

Hermann, I hope you don't mind, but I pushed directly to your PR instead of creating another PR, etc.

@jeremy-murphy
Copy link
Contributor

Sorry, I won't push on to someone else's PR again like that. I thought it was the simplest thing to do at the time, but code is never as simple as I hope. :) So I created a new PR with your commits in #412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants